Conversation
CI CommandsThe following CI workflows run automatically on every push and pull request:
The following commands can be used by maintainers to trigger additional tests that require access to secrets:
|
|
@claude can you fix the ci issues? |
|
Claude finished @luccabb's task in 1m 44s —— View job Fixing CI Issues
Root CauseBoth FixApply this change to require github.com/stretchr/testify v1.10.0
+
+require (
+ github.com/davecgh/go-spew v1.1.1 // indirect
+ github.com/pmezard/go-difflib v1.0.0 // indirect
+ gopkg.in/yaml.v3 v3.0.1 // indirect
+)Or simply run from the repo root: cd shelper && go mod tidyThen commit and push the updated
|
Summary: - Renames shelper module path from github.com/fairinternal/fair-cluster-monitoring/shelper to github.com/facebookresearch/gcm/shelper to match the public repo - Updates slurmprocessor to reference the renamed shelper module, fixes package declaration from main to slurmprocessor, and removes the internal attributesprocessor dependency (used an internal package that external modules can't import) - Both modules are now published and fetchable via go get github.com/facebookresearch/gcm/shelper@v0.0.1 and go get github.com/facebookresearch/gcm/slurmprocessor@v0.0.1 - Updates Helm chart values and Kubernetes deployment docs Test Plan: - go get github.com/facebookresearch/gcm/shelper@v0.0.1 resolves successfully from a fresh module - go get github.com/facebookresearch/gcm/slurmprocessor@v0.0.1 resolves successfully from a fresh module - Helm chart deploys correctly with updated values Reviewed By: gunchu Differential Revision: D96259734 Pulled By: luccabb
8034970 to
d4a7ccb
Compare
Summary: - Renames shelper module path from github.com/fairinternal/fair-cluster-monitoring/shelper to github.com/facebookresearch/gcm/shelper to match the public repo - Updates slurmprocessor to reference the renamed shelper module, fixes package declaration from main to slurmprocessor, and removes the internal attributesprocessor dependency (used an internal package that external modules can't import) - Both modules are now published and fetchable via go get github.com/facebookresearch/gcm/shelper@v0.0.1 and go get github.com/facebookresearch/gcm/slurmprocessor@v0.0.1 - Updates Helm chart values and Kubernetes deployment docs Pull Request resolved: #95 Test Plan: - go get github.com/facebookresearch/gcm/shelper@v0.0.1 resolves successfully from a fresh module - go get github.com/facebookresearch/gcm/slurmprocessor@v0.0.1 resolves successfully from a fresh module - Helm chart deploys correctly with updated values Reviewed By: gunchu Differential Revision: D96259734 Pulled By: luccabb
d4a7ccb to
2e4cddc
Compare
Summary
attributesprocessor dependency (used an internal package that external modules can't import)
github.com/facebookresearch/gcm/slurmprocessor@v0.0.1
Test Plan